c/ooni-probe-cli
Watch
1
0
Fork
You've already forked ooni-probe-cli
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

refactor(resolver): add CloseIdleConnections to SerialResolver (#502)

Browse source 
While there, generally convert more code to internal testing
and to using pointer receivers as well.

Part of https://github.com/ooni/probe/issues/1591.
This commit is contained in:
Simone Basso 2021-09-09 20:58:04 +02:00 • committed by GitHub
commit b3c36b5c7f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 55 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

20
internal/engine/netx/netx_test.go
View file

@ -676,7 +676,7 @@ func TestNewDNSClientPowerdnsDoH(t *testing.T) {
if err != nil {
t.Fatal(err)
}
r, ok := dnsclient.Resolver.(resolver.SerialResolver)
r, ok := dnsclient.Resolver.(*resolver.SerialResolver)
if !ok {
t.Fatal("not the resolver we expected")
}
@ -692,7 +692,7 @@ func TestNewDNSClientGoogleDoH(t *testing.T) {
if err != nil {
t.Fatal(err)
}
r, ok := dnsclient.Resolver.(resolver.SerialResolver)
r, ok := dnsclient.Resolver.(*resolver.SerialResolver)
if !ok {
t.Fatal("not the resolver we expected")
}
@ -708,7 +708,7 @@ func TestNewDNSClientCloudflareDoH(t *testing.T) {
if err != nil {
t.Fatal(err)
}
r, ok := dnsclient.Resolver.(resolver.SerialResolver)
r, ok := dnsclient.Resolver.(*resolver.SerialResolver)
if !ok {
t.Fatal("not the resolver we expected")
}
@ -725,7 +725,7 @@ func TestNewDNSClientCloudflareDoHSaver(t *testing.T) {
if err != nil {
t.Fatal(err)
}
r, ok := dnsclient.Resolver.(resolver.SerialResolver)
r, ok := dnsclient.Resolver.(*resolver.SerialResolver)
if !ok {
t.Fatal("not the resolver we expected")
}
@ -745,7 +745,7 @@ func TestNewDNSClientUDP(t *testing.T) {
if err != nil {
t.Fatal(err)
}
r, ok := dnsclient.Resolver.(resolver.SerialResolver)
r, ok := dnsclient.Resolver.(*resolver.SerialResolver)
if !ok {
t.Fatal("not the resolver we expected")
}
@ -762,7 +762,7 @@ func TestNewDNSClientUDPDNSSaver(t *testing.T) {
if err != nil {
t.Fatal(err)
}
r, ok := dnsclient.Resolver.(resolver.SerialResolver)
r, ok := dnsclient.Resolver.(*resolver.SerialResolver)
if !ok {
t.Fatal("not the resolver we expected")
}
@ -782,7 +782,7 @@ func TestNewDNSClientTCP(t *testing.T) {
if err != nil {
t.Fatal(err)
}
r, ok := dnsclient.Resolver.(resolver.SerialResolver)
r, ok := dnsclient.Resolver.(*resolver.SerialResolver)
if !ok {
t.Fatal("not the resolver we expected")
}
@ -803,7 +803,7 @@ func TestNewDNSClientTCPDNSSaver(t *testing.T) {
if err != nil {
t.Fatal(err)
}
r, ok := dnsclient.Resolver.(resolver.SerialResolver)
r, ok := dnsclient.Resolver.(*resolver.SerialResolver)
if !ok {
t.Fatal("not the resolver we expected")
}
@ -827,7 +827,7 @@ func TestNewDNSClientDoT(t *testing.T) {
if err != nil {
t.Fatal(err)
}
r, ok := dnsclient.Resolver.(resolver.SerialResolver)
r, ok := dnsclient.Resolver.(*resolver.SerialResolver)
if !ok {
t.Fatal("not the resolver we expected")
}
@ -848,7 +848,7 @@ func TestNewDNSClientDoTDNSSaver(t *testing.T) {
if err != nil {
t.Fatal(err)
}
r, ok := dnsclient.Resolver.(resolver.SerialResolver)
r, ok := dnsclient.Resolver.(*resolver.SerialResolver)
if !ok {
t.Fatal("not the resolver we expected")
}