c/ooni-probe-cli
Watch
1
0
Fork
You've already forked ooni-probe-cli
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

chore: link new TODOs with the relevant issues (#321)

Browse source 
Part of https://github.com/ooni/probe/issues/985
This commit is contained in:
Simone Basso 2021-04-29 18:43:31 +02:00 • committed by GitHub
commit 9d5a3321af
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
pkg/oonimkall/internal/tasks/runner.go
View file

@ -77,6 +77,7 @@ func (r *Runner) newsession(ctx context.Context, logger *ChanLogger) (*engine.Se
}
// TODO(bassosimone): write tests for this functionality
// See https://github.com/ooni/probe/issues/1465.
var proxyURL *url.URL
if r.settings.Proxy != "" {
var err error

1
pkg/oonimkall/session.go
View file

@ -169,6 +169,7 @@ func newSessionWithContext(ctx context.Context, config *SessionConfig) (*Session
}
// TODO(bassosimone): write tests for this functionality.
// See https://github.com/ooni/probe/issues/1465.
var proxyURL *url.URL
if config.Proxy != "" {
var err error