c/ooni-probe-cli
Watch
1
0
Fork
You've already forked ooni-probe-cli
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

feat: clearly indicate which resolver we're using (#885)

Browse source 
See what we documented at https://github.com/ooni/spec/pull/257

Reference issue: https://github.com/ooni/probe/issues/2238

See also the related ooni/spec PR: https://github.com/ooni/spec/pull/257

See also https://github.com/ooni/probe/issues/2237

While there, bump webconnectivity@v0.5 version because this change
has an impact onto the generated data format.

The drop in coverage is unavoidable because we've written some
tests for `measurex` to ensure we deal with DNS resolvers and transport
names correctly depending on the splitting policy we use.

(However, `measurex` is only used for the `tor` experiment and, per
the step-by-step design document, new experiments should use
`measurexlite` instead, so this is hopefully fine(TM).)

While there, fix a broken integration test that does not run in `-short` mode.
This commit is contained in:
Simone Basso 2022-08-27 15:47:48 +02:00 • committed by GitHub
commit 8a0c062844
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
19 changed files with 362 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

12
internal/netxlite/resolvercore_test.go
View file

@ -347,7 +347,7 @@ func TestResolverLogger(t *testing.T) {
return expected, nil
},
MockNetwork: func() string {
return "system"
return StdlibResolverGetaddrinfo
},
MockAddress: func() string {
return ""
@ -381,7 +381,7 @@ func TestResolverLogger(t *testing.T) {
return nil, expected
},
MockNetwork: func() string {
return "system"
return StdlibResolverGetaddrinfo
},
MockAddress: func() string {
return ""
@ -420,7 +420,7 @@ func TestResolverLogger(t *testing.T) {
return expected, nil
},
MockNetwork: func() string {
return "system"
return StdlibResolverGetaddrinfo
},
MockAddress: func() string {
return ""
@ -454,7 +454,7 @@ func TestResolverLogger(t *testing.T) {
return nil, expected
},
MockNetwork: func() string {
return "system"
return StdlibResolverGetaddrinfo
},
MockAddress: func() string {
return ""
@ -509,7 +509,7 @@ func TestResolverLogger(t *testing.T) {
return expected, nil
},
MockNetwork: func() string {
return "system"
return StdlibResolverGetaddrinfo
},
MockAddress: func() string {
return ""
@ -543,7 +543,7 @@ func TestResolverLogger(t *testing.T) {
return nil, expected
},
MockNetwork: func() string {
return "system"
return StdlibResolverGetaddrinfo
},
MockAddress: func() string {
return ""