c/ooni-probe-cli
Watch
1
0
Fork
You've already forked ooni-probe-cli
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix a very annoying logic bug in URL insertion

Browse source 
Write test case for it
This commit is contained in:
Arturo Filastò 2018-09-12 18:47:57 +02:00
commit 7f5df07782
4 changed files with 63 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

2
nettests/nettests.go
View file

@ -176,12 +176,12 @@ func (c *Controller) Init(nt *mk.Nettest) error {
nt.On("status.measurement_start", func(e mk.Event) {
log.Debugf(color.RedString(e.Key))
idx := e.Value.Idx
urlID := sql.NullInt64{Int64: 0, Valid: false}
if c.inputIdxMap != nil {
urlID = sql.NullInt64{Int64: c.inputIdxMap[idx], Valid: true}
}
log.Debugf("👁 %d %s %d", idx, e.Value.Input, urlID.Int64)
msmt, err := database.CreateMeasurement(c.Ctx.DB, reportID, testName, resultID, reportFilePath, urlID)
if err != nil {
log.WithError(err).Error("Failed to create measurement")