c/ooni-probe-cli
Watch
1
0
Fork
You've already forked ooni-probe-cli
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix a very annoying logic bug in URL insertion

Browse source 
Write test case for it
This commit is contained in:
Arturo Filastò 2018-09-12 18:47:57 +02:00
commit 7f5df07782
4 changed files with 63 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

31
internal/database/actions_test.go
View file

@ -132,12 +132,27 @@ func TestURLCreation(t *testing.T) {
t.Fatal(err)
}
newID1, err := CreateOrUpdateURL(sess, "https://google.com", "SRCH", "XX")
newID1, err := CreateOrUpdateURL(sess, "https://google.com", "GMB", "XX")
if err != nil {
t.Fatal(err)
}
newID2, err := CreateOrUpdateURL(sess, "https://google.com", "GMB", "XX")
newID2, err := CreateOrUpdateURL(sess, "https://google.com", "SRCH", "XX")
if err != nil {
t.Fatal(err)
}
newID3, err := CreateOrUpdateURL(sess, "https://facebook.com", "GRP", "XX")
if err != nil {
t.Fatal(err)
}
newID4, err := CreateOrUpdateURL(sess, "https://facebook.com", "GMP", "XX")
if err != nil {
t.Fatal(err)
}
newID5, err := CreateOrUpdateURL(sess, "https://google.com", "SRCH", "XX")
if err != nil {
t.Fatal(err)
}
@ -145,6 +160,18 @@ func TestURLCreation(t *testing.T) {
if newID2 != newID1 {
t.Error("inserting the same URL with different category code should produce the same result")
}
if newID3 == newID1 {
t.Error("inserting different URL should produce different ids")
}
if newID4 != newID3 {
t.Error("inserting the same URL with different category code should produce the same result")
}
if newID5 != newID1 {
t.Error("the ID of google should still be the same")
}
}
func TestPerformanceTestKeys(t *testing.T) {