refactor(netx): move construction logic outside package (#798)
For testability, replace most if-based construction logic with calls to well-tested factories living in other packages. While there, acknowledge that a bunch of types could now be private and make them private, modifying the code to call the public factories allowing to construct said types instead. Part of https://github.com/ooni/probe/issues/2121
This commit is contained in:
parent
2d3d5d9cdc
commit
6b85dfce88
20 changed files with 475 additions and 184 deletions
|
|
@ -285,10 +285,10 @@ func (e *Experiment) OpenReportContext(ctx context.Context) error {
|
|||
}
|
||||
// use custom client to have proper byte accounting
|
||||
httpClient := &http.Client{
|
||||
Transport: &bytecounter.HTTPTransport{
|
||||
HTTPTransport: e.session.httpDefaultTransport, // proxy is OK
|
||||
Counter: e.byteCounter,
|
||||
},
|
||||
Transport: bytecounter.WrapHTTPTransport(
|
||||
e.session.httpDefaultTransport, // proxy is OK
|
||||
e.byteCounter,
|
||||
),
|
||||
}
|
||||
client, err := e.session.NewProbeServicesClient(ctx)
|
||||
if err != nil {
|
||||
|
|
|
|||
Loading…
Reference in a new issue