fix(dnscheck): log "ok" rather than "<nil>" on success (#695)

See https://github.com/ooni/probe/issues/2020
2022-02-16 19:47:44 +00:00 · 2022-02-16 19:47:44 +00:00 · 6a63f1b044
commit 6a63f1b044
parent 88236a4352
5 changed files with 33 additions and 2 deletions
--- a/internal/engine/experiment/dnscheck/dnscheck.go
+++ b/internal/engine/experiment/dnscheck/dnscheck.go
@ -272,7 +272,7 @@ func Collect(ctx context.Context, multi urlgetter.Multi, inputs []urlgetter.Mult
 			count++
 			percentage := float64(count) / float64(expect)
 			callbacks.OnProgress(percentage, fmt.Sprintf(
-				"dnscheck: measure %s: %+v", entry.Input.Config.ResolverURL, entry.Err,
+				"dnscheck: measure %s: %+v", entry.Input.Config.ResolverURL, model.ErrorToStringOrOK(entry.Err),
 			))
 			outputch <- entry
 		}