refactor(engine): *http.Client -> model.HTTPClient (#836)

This diff makes the implementation of the engine package more
abstract by changing HTTPClient() to return a model.HTTPClient
as opposed to returning an *http.Client.

Part of https://github.com/ooni/probe/issues/2184
This commit is contained in:
Simone Basso 2022-07-08 11:08:10 +02:00 committed by GitHub
commit 6019b25baf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 10 additions and 9 deletions

View file

@ -25,7 +25,6 @@ package probeservices
import (
"errors"
"net/http"
"net/url"
"github.com/ooni/probe-cli/v3/internal/atomicx"
@ -56,7 +55,7 @@ var (
// Session is how this package sees a Session.
type Session interface {
DefaultHTTPClient() *http.Client
DefaultHTTPClient() model.HTTPClient
KeyValueStore() model.KeyValueStore
Logger() model.Logger
ProxyURL() *url.URL