feat: tlsping and tcpping using step-by-step (#815)

## Checklist

- [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request: https://github.com/ooni/probe/issues/2158
- [x] if you changed anything related how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: https://github.com/ooni/spec/pull/250

## Description

This diff refactors the codebase to reimplement tlsping and tcpping
to use the step-by-step measurements style.

See docs/design/dd-003-step-by-step.md for more information on the
step-by-step measurement style.
This commit is contained in:
Simone Basso 2022-07-01 12:22:22 +02:00 committed by GitHub
commit 5ebdeb56ca
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
48 changed files with 2825 additions and 299 deletions

View file

@ -4,7 +4,7 @@ import (
"testing"
"github.com/google/go-cmp/cmp"
"github.com/ooni/probe-cli/v3/internal/fakefill"
"github.com/ooni/probe-cli/v3/internal/testingx"
)
func TestArchivalExtSpec(t *testing.T) {
@ -301,7 +301,7 @@ func TestHTTPBody(t *testing.T) {
// we make a mistake and apply the above change (which will in turn
// break correct JSON serialization), the this test will fail.
var body ArchivalHTTPBody
ff := &fakefill.Filler{}
ff := &testingx.FakeFiller{}
ff.Fill(&body)
data := ArchivalMaybeBinaryData(body)
if diff := cmp.Diff(body, data); diff != "" {