c/ooni-probe-cli
Watch
1
0
Fork
You've already forked ooni-probe-cli
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

doc(netx): reference issue mentioning future improvements (#802)

Browse source 
See https://github.com/ooni/probe/issues/2121#issuecomment-1147424810
This commit is contained in:
Simone Basso 2022-06-06 15:16:30 +02:00 • committed by GitHub
commit 57e207e644
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 20 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

7
internal/engine/netx/dnstransport.go
View file

@ -6,6 +6,7 @@ package netx
// TODO(bassosimone): this code should be refactored to return
// a DNSTransport rather than a model.Resolver. With this in mind,
// I've named this file dnstransport.go.
// TODO(https://github.com/ooni/probe/issues/2121#issuecomment-1147424810)
//
import (
@ -45,6 +46,8 @@ func NewDNSClient(config Config, URL string) (model.Resolver, error) {
// with the option to override the default Hostname and SNI.
func NewDNSClientWithOverrides(config Config, URL, hostOverride, SNIOverride,
TLSVersion string) (model.Resolver, error) {
// We should split this function in smaller and testable units
// TODO(https://github.com/ooni/probe/issues/2121#issuecomment-1147424810)
switch URL {
case "doh://powerdns":
URL = "https://doh.powerdns.org/"
@ -132,6 +135,10 @@ func makeValidEndpoint(URL *url.URL) (string, error) {
if _, _, err := net.SplitHostPort(URL.Host); err == nil {
return URL.Host, nil
}
// Here we should add a test case for when the host is empty
// TODO(https://github.com/ooni/probe/issues/2121#issuecomment-1147424810)
// The second step is to assume that appending the default port
// to a host parsed by url.Parse should be giving us a valid
// endpoint. The possibilities in fact are: