cleanup: remove unnecessary legacy interfaces (#656)
This diff addresses another point of https://github.com/ooni/probe/issues/1956: > - [ ] observe that we're still using a bunch of private interfaces for common interfaces such as the `Dialer`, so we can get rid of these private interfaces and always use the ones in `model`, which allows us to remove a bunch of legacy wrappers Additional cleanups may still be possible. The more I cleanup, the more I see there's extra legacy code we can dispose of (which seems good?).
This commit is contained in:
parent
1c057d322d
commit
566c6b246a
76 changed files with 326 additions and 734 deletions
|
|
@ -5,14 +5,14 @@ import (
|
|||
"net"
|
||||
"time"
|
||||
|
||||
"github.com/ooni/probe-cli/v3/internal/engine/netx"
|
||||
"github.com/ooni/probe-cli/v3/internal/model"
|
||||
)
|
||||
|
||||
// Dialer creates net.Conn instances where (1) we delay writes if
|
||||
// a delay is configured and (2) we split outgoing buffers if there
|
||||
// is a configured splitter function.
|
||||
type Dialer struct {
|
||||
netx.Dialer
|
||||
model.Dialer
|
||||
Delay time.Duration
|
||||
Splitter func([]byte) [][]byte
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue