c/ooni-probe-cli
Watch
1
0
Fork
You've already forked ooni-probe-cli
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

feat(oohelperd): log messages at info level (#896)

Browse source 
We're using a request-specific logger where we also print the ID
of the request. This design helps to observe logs produced by
concurrent requests.

Part of https://github.com/ooni/probe/issues/2183

While there, fix https://github.com/ooni/probe/issues/2241
This commit is contained in:
Simone Basso 2022-08-28 22:26:58 +02:00 • committed by GitHub
commit 4241ee4bc1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 225 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

6
internal/cmd/oohelperd/http_test.go
View file

@ -20,8 +20,9 @@ func TestHTTPDoWithInvalidURL(t *testing.T) {
wg.Add(1)
go httpDo(ctx, &httpConfig{
Headers: nil,
Logger: model.DiscardLogger,
MaxAcceptableBody: 1 << 24,
NewClient: func() model.HTTPClient {
NewClient: func(model.Logger) model.HTTPClient {
return http.DefaultClient
},
Out: httpch,
@ -44,8 +45,9 @@ func TestHTTPDoWithHTTPTransportFailure(t *testing.T) {
wg.Add(1)
go httpDo(ctx, &httpConfig{
Headers: nil,
Logger: model.DiscardLogger,
MaxAcceptableBody: 1 << 24,
NewClient: func() model.HTTPClient {
NewClient: func(model.Logger) model.HTTPClient {
return &http.Client{
Transport: &mocks.HTTPTransport{
MockRoundTrip: func(req *http.Request) (*http.Response, error) {