feat(oohelperd): log messages at info level (#896)

We're using a request-specific logger where we also print the ID
of the request. This design helps to observe logs produced by
concurrent requests.

Part of https://github.com/ooni/probe/issues/2183

While there, fix https://github.com/ooni/probe/issues/2241
This commit is contained in:
Simone Basso 2022-08-28 22:26:58 +02:00 committed by GitHub
commit 4241ee4bc1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 225 additions and 27 deletions

View file

@ -10,6 +10,7 @@ import (
"strings"
"testing"
"github.com/ooni/probe-cli/v3/internal/atomicx"
"github.com/ooni/probe-cli/v3/internal/model"
"github.com/ooni/probe-cli/v3/internal/model/mocks"
"github.com/ooni/probe-cli/v3/internal/netxlite"
@ -53,17 +54,19 @@ const requestWithoutDomainName = `{
func TestHandlerWorkingAsIntended(t *testing.T) {
handler := &handler{
BaseLogger: model.DiscardLogger,
Indexer: &atomicx.Int64{},
MaxAcceptableBody: 1 << 24,
NewClient: func() model.HTTPClient {
NewClient: func(model.Logger) model.HTTPClient {
return http.DefaultClient
},
NewDialer: func() model.Dialer {
NewDialer: func(model.Logger) model.Dialer {
return netxlite.NewDialerWithStdlibResolver(model.DiscardLogger)
},
NewResolver: func() model.Resolver {
NewResolver: func(model.Logger) model.Resolver {
return netxlite.NewUnwrappedStdlibResolver()
},
NewTLSHandshaker: func() model.TLSHandshaker {
NewTLSHandshaker: func(model.Logger) model.TLSHandshaker {
return netxlite.NewTLSHandshakerStdlib(model.DiscardLogger)
},
}