c/ooni-probe-cli
Watch
1
0
Fork
You've already forked ooni-probe-cli
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

feat(webconnectivity@v0.5): use TLS info from TH (#933)

Browse source 
This diff modifies webconnectivity@v0.5 to take decisions regarding
TLS blocking by using the response from the TH rather than using
questionable heuristics based on inspecting the TLSHandshake list
alone. This change should improve correctness _when_ we're using
the improved TH, which is currently used for 50% of the probes.

See https://github.com/ooni/probe/issues/2257

While there, modify `control.go` to specify which control is being used.
This commit is contained in:
Simone Basso 2022-09-05 11:35:48 +02:00 • committed by GitHub
commit 3766ab2721
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 90 additions and 110 deletions
Download patch file Download diff file Expand all files Collapse all files

11
internal/experiment/webconnectivity/control.go
View file

@ -100,12 +100,13 @@ func (c *Control) Run(parentCtx context.Context) {
}
c.TestKeys.SetControlRequest(creq)
// TODO(bassosimone): the current TH will not perform TLS measurements for
// 443 endpoints. However, we should modify the TH to do that, such that we're
// able to be more confident about TLS measurements results.
// create logger for this operation
ol := measurexlite.NewOperationLogger(c.Logger, "control for %s", creq.HTTPRequest)
ol := measurexlite.NewOperationLogger(
c.Logger,
"control for %s using %s",
creq.HTTPRequest,
c.THAddr,
)
// create an API client
clnt := (&httpx.APIClientTemplate{