feat(webconnectivity@v0.5): use TLS info from TH (#933)
This diff modifies webconnectivity@v0.5 to take decisions regarding TLS blocking by using the response from the TH rather than using questionable heuristics based on inspecting the TLSHandshake list alone. This change should improve correctness _when_ we're using the improved TH, which is currently used for 50% of the probes. See https://github.com/ooni/probe/issues/2257 While there, modify `control.go` to specify which control is being used.
This commit is contained in:
parent
34dc029b33
commit
3766ab2721
7 changed files with 90 additions and 110 deletions
|
|
@ -33,11 +33,6 @@ func (tk *TestKeys) analysisTCPIPToplevel(logger model.Logger) {
|
|||
isfalse = false
|
||||
)
|
||||
|
||||
// TODO(bassosimone): the TH should measure also some of the IP addrs it discovered
|
||||
// and the probe did not discover to improve the analysis. Otherwise, the probe
|
||||
// is fooled by the TH also failing for countries that return random IP addresses
|
||||
// that are actually not working. Yet, ooni/data would definitely see this.
|
||||
|
||||
// walk the list of probe results and compare with TH results
|
||||
for _, entry := range tk.TCPConnect {
|
||||
// skip successful entries
|
||||
|
|
@ -75,7 +70,12 @@ func (tk *TestKeys) analysisTCPIPToplevel(logger model.Logger) {
|
|||
// for the pipeline rather than for the probe.
|
||||
continue
|
||||
}
|
||||
logger.Warnf("TCP/IP: endpoint %s is blocked (see #%d)", epnt, entry.TransactionID)
|
||||
logger.Warnf(
|
||||
"TCP/IP: endpoint %s is blocked (see #%d): %s",
|
||||
epnt,
|
||||
entry.TransactionID,
|
||||
*failure,
|
||||
)
|
||||
entry.Status.Blocked = &istrue
|
||||
tk.BlockingFlags |= analysisFlagTCPIPBlocking
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue