refactor(session.go): replace engine/netx with netxlite (#767)
This diff replaces engine/netx code with netxlite code in the engine/session.go file. To this end, we needed to move some code from engine/netx to netxlite. While there, we did review and improve the unit tests. A notable change in this diff is (or seems to be) that in engine/session.go we're not filtering for bogons anymore so that, in principle, we could believe a resolver returning to us bogon IP addresses for OONI services. However, I did not bother with changing bogons filtering because the sessionresolver package is already filtering for bogons, so it is actually okay to avoid doing that again the session.go code. See: https://github.com/ooni/probe-cli/blob/v3.15.0-alpha.1/internal/engine/internal/sessionresolver/resolvermaker.go#L88 There are two reference issues for this cleanup: 1. https://github.com/ooni/probe/issues/2115 2. https://github.com/ooni/probe/issues/2121
This commit is contained in:
parent
595d0744db
commit
314c3c934d
16 changed files with 466 additions and 347 deletions
101
internal/bytecounter/http.go
Normal file
101
internal/bytecounter/http.go
Normal file
|
|
@ -0,0 +1,101 @@
|
|||
package bytecounter
|
||||
|
||||
import (
|
||||
"io"
|
||||
"net/http"
|
||||
|
||||
"github.com/ooni/probe-cli/v3/internal/model"
|
||||
)
|
||||
|
||||
// HTTPTransport is a model.HTTPTransport that counts bytes.
|
||||
type HTTPTransport struct {
|
||||
HTTPTransport model.HTTPTransport
|
||||
Counter *Counter
|
||||
}
|
||||
|
||||
// NewHTTPTransport creates a new byte-counting-aware HTTP transport.
|
||||
func NewHTTPTransport(txp model.HTTPTransport, counter *Counter) model.HTTPTransport {
|
||||
return &HTTPTransport{
|
||||
HTTPTransport: txp,
|
||||
Counter: counter,
|
||||
}
|
||||
}
|
||||
|
||||
var _ model.HTTPTransport = &HTTPTransport{}
|
||||
|
||||
// CloseIdleConnections implements model.HTTPTransport.CloseIdleConnections.
|
||||
func (txp *HTTPTransport) CloseIdleConnections() {
|
||||
txp.HTTPTransport.CloseIdleConnections()
|
||||
}
|
||||
|
||||
// RoundTrip implements model.HTTPTRansport.RoundTrip
|
||||
func (txp *HTTPTransport) RoundTrip(req *http.Request) (*http.Response, error) {
|
||||
if req.Body != nil {
|
||||
req.Body = &httpBodyWrapper{
|
||||
account: txp.Counter.CountBytesSent,
|
||||
rc: req.Body,
|
||||
}
|
||||
}
|
||||
txp.estimateRequestMetadata(req)
|
||||
resp, err := txp.HTTPTransport.RoundTrip(req)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
txp.estimateResponseMetadata(resp)
|
||||
resp.Body = &httpBodyWrapper{
|
||||
account: txp.Counter.CountBytesReceived,
|
||||
rc: resp.Body,
|
||||
}
|
||||
return resp, nil
|
||||
}
|
||||
|
||||
// Network implements model.HTTPTransport.Network.
|
||||
func (txp *HTTPTransport) Network() string {
|
||||
return txp.HTTPTransport.Network()
|
||||
}
|
||||
|
||||
func (txp *HTTPTransport) estimateRequestMetadata(req *http.Request) {
|
||||
txp.Counter.CountBytesSent(len(req.Method))
|
||||
txp.Counter.CountBytesSent(len(req.URL.String()))
|
||||
for key, values := range req.Header {
|
||||
for _, value := range values {
|
||||
txp.Counter.CountBytesSent(len(key))
|
||||
txp.Counter.CountBytesSent(len(": "))
|
||||
txp.Counter.CountBytesSent(len(value))
|
||||
txp.Counter.CountBytesSent(len("\r\n"))
|
||||
}
|
||||
}
|
||||
txp.Counter.CountBytesSent(len("\r\n"))
|
||||
}
|
||||
|
||||
func (txp *HTTPTransport) estimateResponseMetadata(resp *http.Response) {
|
||||
txp.Counter.CountBytesReceived(len(resp.Status))
|
||||
for key, values := range resp.Header {
|
||||
for _, value := range values {
|
||||
txp.Counter.CountBytesReceived(len(key))
|
||||
txp.Counter.CountBytesReceived(len(": "))
|
||||
txp.Counter.CountBytesReceived(len(value))
|
||||
txp.Counter.CountBytesReceived(len("\r\n"))
|
||||
}
|
||||
}
|
||||
txp.Counter.CountBytesReceived(len("\r\n"))
|
||||
}
|
||||
|
||||
type httpBodyWrapper struct {
|
||||
account func(int)
|
||||
rc io.ReadCloser
|
||||
}
|
||||
|
||||
var _ io.ReadCloser = &httpBodyWrapper{}
|
||||
|
||||
func (r *httpBodyWrapper) Read(p []byte) (int, error) {
|
||||
count, err := r.rc.Read(p)
|
||||
if count > 0 {
|
||||
r.account(count)
|
||||
}
|
||||
return count, err
|
||||
}
|
||||
|
||||
func (r *httpBodyWrapper) Close() error {
|
||||
return r.rc.Close()
|
||||
}
|
||||
Loading…
Reference in a new issue