c/ooni-probe-cli
Watch
1
0
Fork
You've already forked ooni-probe-cli
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

refactor: cleaner way of passing a UDPConn around (#421)

Browse source 
* refactor: cleaner way of passing a UDPConn around

Also part of https://github.com/ooni/probe/issues/1505

* Update internal/engine/netx/quicdialer/connectionstate.go
This commit is contained in:
Simone Basso 2021-07-01 21:56:29 +02:00 • committed by GitHub
commit 250a595f89
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 33 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

5
internal/netxmocks/quic.go
View file

@ -6,15 +6,16 @@ import (
"net"
"github.com/lucas-clemente/quic-go"
"github.com/ooni/probe-cli/v3/internal/quicx"
)
// QUICListener is a mockable netxlite.QUICListener.
type QUICListener struct {
MockListen func(addr *net.UDPAddr) (net.PacketConn, error)
MockListen func(addr *net.UDPAddr) (quicx.UDPConn, error)
}
// Listen calls MockListen.
func (ql *QUICListener) Listen(addr *net.UDPAddr) (net.PacketConn, error) {
func (ql *QUICListener) Listen(addr *net.UDPAddr) (quicx.UDPConn, error) {
return ql.MockListen(addr)
}

3
internal/netxmocks/quic_test.go
View file

@ -9,12 +9,13 @@ import (
"testing"
"github.com/lucas-clemente/quic-go"
"github.com/ooni/probe-cli/v3/internal/quicx"
)
func TestQUICListenerListen(t *testing.T) {
expected := errors.New("mocked error")
ql := &QUICListener{
MockListen: func(addr *net.UDPAddr) (net.PacketConn, error) {
MockListen: func(addr *net.UDPAddr) (quicx.UDPConn, error) {
return nil, expected
},
}